Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Quickstart GIFs #985

Merged
merged 3 commits into from
Jun 11, 2024
Merged

Fix Quickstart GIFs #985

merged 3 commits into from
Jun 11, 2024

Conversation

johnzl-777
Copy link
Collaborator

The GIFs in the quickstart don't seem to render on the live version of the docs, I think this is fixable with the following PR.

The odd thing is this makes the local rendering via pdm doc not work ):

Copy link
Contributor

github-actions bot commented Jun 7, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-06-11 13:46 UTC

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.91%. Comparing base (bb8ab82) to head (66dec3b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #985   +/-   ##
=======================================
  Coverage   89.91%   89.91%           
=======================================
  Files         110      110           
  Lines        8132     8132           
=======================================
  Hits         7312     7312           
  Misses        820      820           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Roger-luo Roger-luo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is strange, cuz

https://bloqade.quera.com/latest/assets/quick_start/jupyter-hints.gif

returns the correct element. And since the website URL is latest, the absolute address should work...

@Roger-luo
Copy link
Member

ah the link on the website is missing version number path, so it was looking for https://bloqade.quera.com/assets/quick_start/jupyter-hints.gif instead. I think the correct fix is somehow include the version number as website root path. I don't relative path is the right fix and as you can see it didn't work locally.

@johnzl-777
Copy link
Collaborator Author

I had a chat with @weinbe58 about this I think we just have to use the standard markdown syntax instead of the HTML. I remember we opted for the HTML earlier when we wanted to control the image sizes but in the current state we don't even do that. Plus the GIFs are all auto-centered anyways which makes the need for the align=center attribute moot.

@weinbe58 weinbe58 merged commit 17585b2 into main Jun 11, 2024
10 checks passed
@weinbe58 weinbe58 deleted the john/fix-quickstart-gifs branch June 11, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants