-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Quickstart GIFs #985
Fix Quickstart GIFs #985
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #985 +/- ##
=======================================
Coverage 89.91% 89.91%
=======================================
Files 110 110
Lines 8132 8132
=======================================
Hits 7312 7312
Misses 820 820 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is strange, cuz
https://bloqade.quera.com/latest/assets/quick_start/jupyter-hints.gif
returns the correct element. And since the website URL is latest, the absolute address should work...
ah the link on the website is missing version number path, so it was looking for https://bloqade.quera.com/assets/quick_start/jupyter-hints.gif instead. I think the correct fix is somehow include the version number as website root path. I don't relative path is the right fix and as you can see it didn't work locally. |
I had a chat with @weinbe58 about this I think we just have to use the standard markdown syntax instead of the HTML. I remember we opted for the HTML earlier when we wanted to control the image sizes but in the current state we don't even do that. Plus the GIFs are all auto-centered anyways which makes the need for the |
The GIFs in the quickstart don't seem to render on the live version of the docs, I think this is fixable with the following PR.
The odd thing is this makes the local rendering via
pdm doc
not work ):