Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for f32 in FFT computations #12

Closed
astral4 opened this issue Feb 16, 2024 · 1 comment · Fixed by #17
Closed

Support for f32 in FFT computations #12

astral4 opened this issue Feb 16, 2024 · 1 comment · Fixed by #17
Assignees
@smu160
Labels
enhancement New feature or request

Comments

@astral4
Copy link

astral4 commented Feb 16, 2024

In rustfft, it's possible to compute Fourier transforms of sequences with either 32-bit or 64-bit floats. This is done by generalizing over an FftNum trait. However, phastft only supports 64-bit floats. Is it possible to add support for f32 in phastft?
@smu160 smu160 added the enhancement New feature or request label Feb 16, 2024
@smu160 smu160 self-assigned this Feb 16, 2024
@smu160
Copy link
Member

smu160 commented Feb 16, 2024

Hi @astral4,

That's a great point. Since we also need f32 support for Spinoza, this is next on my to-do list.

Thank you!

Best,
Saveliy

@smu160 smu160 mentioned this issue Mar 4, 2024
Closed
@smu160 smu160 linked a pull request Mar 18, 2024 that will close this issue
Add support for f32, as well as f64 #17
Merged
@smu160 smu160 closed this as completed in #17 Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smu160 smu160

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for f32, as well as f64 QuState/PhastFT
2 participants
@smu160 @astral4