Add support for f32, as well as f64
#17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems like it fails to build on CI with a syntax error? |
|
Yes. Sorry, I should have converted this to a draft. I have local changes almost ready to check-in. They should address the aforementioned issue, as well as others. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17 +/- ##
==========================================
+ Coverage 94.28% 97.25% +2.96%
==========================================
Files 7 7
Lines 805 765 -40
==========================================
- Hits 759 744 -15
+ Misses 46 21 -25 ☔ View full report in Codecov by Sentry. |
- Make float comparison generic for f32/f64 - Add f32/f64 tests for twiddles using macros
smu160
commented
Apr 1, 2024
| @@ -102,7 +102,7 @@ macro_rules! impl_fft_with_opts_and_plan_for { | |||
| if t < n - 1 { | |||
| filter_twiddles(twiddles_re, twiddles_im); | |||
| } | |||
| if chunk_size >= 16 { | |||
| if chunk_size >= $lanes * 2 { | |||
There was a problem hiding this comment.
@Shnatsel Now we just use # of lanes * 2 when executing this check
smu160
commented
Apr 1, 2024
| @@ -49,7 +49,7 @@ macro_rules! fft_butterfly_n_simd { | |||
| } | |||
|
|
|||
| fft_butterfly_n_simd!(fft_64_chunk_n_simd, f64, 8, f64x8); | |||
| fft_butterfly_n_simd!(fft_32_chunk_n_simd, f32, 8, f32x8); | |||
| fft_butterfly_n_simd!(fft_32_chunk_n_simd, f32, 16, f32x16); | |||
There was a problem hiding this comment.
@Shnatsel Bumped up # of lanes to 16 when using AVX-512 and f32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should address issue #14