Make planner reusable #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Planner should be re-usable so it can be re-used for FFT's of the same size - Add regression tests to make sure `fft_64`/`fft_32` gives the same results as `fft_64_with_opts_and_plan`/`fft_32_with_opts_and_plan`
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #33 +/- ##
=======================================
Coverage ? 99.16%
=======================================
Files ? 8
Lines ? 841
Branches ? 0
=======================================
Hits ? 834
Misses ? 7
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Shnatsel
reviewed
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Planner should be re-usable so it can be re-used for FFT's of the same size
Add regression tests to make sure
fft_64/fft_32gives the same results asfft_64_with_opts_and_plan/fft_32_with_opts_and_plan@Shnatsel I also added a
criterionbased benchmark based on these benchmarks. In addition, this new benchmark takes into account thatPlanner32/Planner64are now re-usable.I am thinking we can use criterion's
BenchmarkGroupto addrust-fftw3andRustFFTfor comparison. Ideally, this would replace the current benchmarks.