Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

104 transfer opensquirrel tutorial from colab to mkdocs #113

Merged
merged 7 commits into from
Mar 25, 2024
Merged

104 transfer opensquirrel tutorial from colab to mkdocs #113

merged 7 commits into from
Mar 25, 2024

Conversation

elenbaasc
Copy link
Collaborator

No description provided.

@elenbaasc elenbaasc requested review from pablolh and rturrado March 8, 2024 13:15
@elenbaasc elenbaasc removed the request for review from pablolh March 20, 2024 13:30
rturrado
rturrado reviewed Mar 20, 2024
View reviewed changes
Copy link
Contributor

@rturrado rturrado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way I can generate the GitHub pages documentation locally, so that I can view the final results of the changes?

@elenbaasc
Copy link
Collaborator Author

You can use:

mkdocs serve

and then visit the url in the output.

@rturrado
Copy link
Contributor

You can use:

mkdocs serve

and then visit the url in the output.

Thanks!

rturrado
rturrado previously approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@rturrado rturrado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, Chris!

I have a patch for one issue I saw with the documentation for CircuitBuilder. Do you think you could add it to this PR?

Fixed_CircuitBuilder_documentation_.patch

rturrado
rturrado approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@rturrado rturrado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@elenbaasc elenbaasc merged commit 7c4cce5 into develop Mar 25, 2024
17 checks passed
@elenbaasc elenbaasc deleted the 104-transfer-opensquirrel-tutorial-from-colab-to-mkdocs branch March 25, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rturrado rturrado rturrado approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elenbaasc @rturrado