Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

72 handle measure instructions and bit registers #144

Merged
merged 8 commits into from
Apr 18, 2024
Merged

72 handle measure instructions and bit registers #144

merged 8 commits into from
Apr 18, 2024

Conversation

juanboschero
Copy link
Collaborator

No description provided.

@juanboschero juanboschero linked an issue Apr 11, 2024 that may be closed by this pull request
Handle measure instructions and bit registers #72
Closed
@elenbaasc elenbaasc self-requested a review April 11, 2024 09:49
elenbaasc
elenbaasc reviewed Apr 12, 2024
View reviewed changes
opensquirrel/operation_library.py Outdated Show resolved Hide resolved
opensquirrel/circuit.py Outdated Show resolved Hide resolved
opensquirrel/default_measurements.py Outdated Show resolved Hide resolved
opensquirrel/default_measurements.py Outdated Show resolved Hide resolved
opensquirrel/merger.py Outdated Show resolved Hide resolved
opensquirrel/squirrel_ir.py Outdated Show resolved Hide resolved
opensquirrel/squirrel_ir.py Outdated Show resolved Hide resolved
opensquirrel/squirrel_ir.py Outdated Show resolved Hide resolved
opensquirrel/writer.py Outdated Show resolved Hide resolved
test/test_integration.py Show resolved Hide resolved
@elenbaasc
Copy link
Collaborator

elenbaasc commented Apr 15, 2024 •
edited
Loading

Note that it is in general up to the reviewer to 'Resolve' a conversation, as they need to determine whether this is the case. If the owner of the PR accepts a code suggestion by the reviewer, then it can be considered to be resolved.

There are still a lot of changes to the files in the antlr folder. These need to be reset, i.e. to their state on develop. And make sure that the tests involving measurements do not rely on the ANTLR parser.

The poetry.lock files seem to still have some conflicts that need to be resolved before we can merge.

rturrado
rturrado reviewed Apr 16, 2024
View reviewed changes
Copy link
Contributor

@rturrado rturrado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

opensquirrel/parsing/antlr/squirrel_ir_from_string.py Outdated Show resolved Hide resolved
opensquirrel/parsing/antlr/squirrel_ir_from_string.py Outdated Show resolved Hide resolved
@elenbaasc elenbaasc self-requested a review April 18, 2024 09:23
@elenbaasc elenbaasc merged commit b798e03 into develop Apr 18, 2024
17 checks passed
@elenbaasc elenbaasc deleted the 72-handle-measure-instructions-and-bit-registers branch April 18, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rturrado rturrado rturrado left review comments

@elenbaasc elenbaasc elenbaasc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle measure instructions and bit registers
3 participants
@juanboschero @elenbaasc @rturrado