-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
152 basic implementation mapper #160
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice work!
Mostly comments on phrasing things in the docstrings.
The _QubitReIndexer
in the general_composer
module seems to do something similar to the relabel
methods you added in the squirrel_ir
module. Do you think we should refactor either one of those? I.e. recycle the QubitReIndexer
for the relabel
methods or remove the _QubitReIndexer
and rely also apply the relabel
methods there?
Co-authored-by: Chris Elenbaas <67630508+elenbaasc@users.noreply.github.com>
How do I activate the github actions. When I made this pull-request the github actions started and some of them failed. Then (I think) I fixed the problem, but now the github actions are not running. What do I need to do to let them run? |
A new commit to this branch should initiate the GitHub actions. Otherwise something is not configured correctly.... |
This Pull Request includes:
IdentityMapper
. Mapping the first virtual qubit to the first physical qubit, etc.HardcodedMapper
. Map using a predefined (hardcoded) mapping.Mapper
.Circuit
object.This also includes the following bugfix:
__eq__
ofMeasure
no longer returns an array of bools.Closes #152