166 type hinting

[S-Linde]

This pull request contains:

• Type hints for all untyped methods
• Fixed incorrect type hints
• Modernized type hints (int | str instead of Union[int, str])

closes #166 and #199

[rturrado]

Great work, Stan!

Just a comment: maybe better to use List and Tuple from typing? Than list and tuple.

I've got errors with Python 3.8 this afternoon because of using list.

[S-Linde]

Great work, Stan!

Just a comment: maybe better to use List and Tuple from typing? Than list and tuple.

I've got errors with Python 3.8 this afternoon because of using list.

I specifically used list over List from typing as that version is depricated (see).

This indeed is not immediately compatible with python3.8. However, in 99% of the cases this can be solved by adding from __future__ import annotations at the top of the file. I though I put this on the top of all relevant files, but I might have missed some. I'll take a closer look later this week.

[rturrado]

Great work, Stan!
Just a comment: maybe better to use List and Tuple from typing? Than list and tuple.
I've got errors with Python 3.8 this afternoon because of using list.

I specifically used list over List from typing as that version is depricated (see).

This indeed is not immediately compatible with python3.8. However, in 99% of the cases this can be solved by adding from __future__ import annotations at the top of the file. I though I put this on the top of all relevant files, but I might have missed some. I'll take a closer look later this week.

Oh wow, good catch. I am gonna file the replacement of List to list as a new issue. Thanks!

[rturrado]

Great work, @S-Linde.

I have only seen that merging error with libqasm_ir_creator.py.

However, according to one error I've just seen in the logs, make sure there are no references to squirrel_ir throughout the code as well. squirrel_ir has been renamed to ir now.

[rturrado]

Hi Stan,

Is this ready to go?

I don't know why I still see refrences to squirrel_ir, and a parser/libqasm/libqasm_ir_creator.py file in the Files changed section.

Thanks!

[S-Linde]

Hi Stan,

Is this ready to go?

I don't know why I still see refrences to squirrel_ir, and a parser/libqasm/libqasm_ir_creator.py file in the Files changed section.

Thanks!

It's almost ready. I'm trying to add a github action for mypy as well. If I get that to work, than it's done

[S-Linde]

Hi Stan,
Is this ready to go?
I don't know why I still see refrences to squirrel_ir, and a parser/libqasm/libqasm_ir_creator.py file in the Files changed section.
Thanks!

It's almost ready. I'm trying to add a github action for mypy as well. If I get that to work, than it's done

Done