9 implement dev tools and document usage #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablolh
suggested changes
Nov 22, 2023
opensquirrel/MatrixExpander.py
Outdated
| @@ -5,7 +5,7 @@ | |||
|
|
|||
|
|
|||
| # This should only be used for testing and on circuits with low number of qubits. | |||
| def getBigMatrix(semantic, qubitOperands, totalQubits): | |||
| def getBigMatrix(semantic: MultiQubitMatrixSemantic, qubitOperands, totalQubits): | |||
There was a problem hiding this comment.
The correct type here is the parent class Semantic in the current code
There was a problem hiding this comment.
Yes, makes sense!
Perhaps we should make Semantic an ABC then?
There was a problem hiding this comment.
It is indeed an ABC! I just only recently discovered that you can use this in Python with an extra module - it's not in the language by default I believe.
There was a problem hiding this comment.
You need to import the abc library indeed (https://docs.python.org/3/library/abc.html).
I was also thinking if it would be an idea to create ABCs for the various passes. And Users can then define new passes based on those interfaces. We have done a similar thing with NetSquid.
pablolh
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.