215 unittest to pytest #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rturrado
reviewed
Jun 5, 2024
There was a problem hiding this comment.
Great work, Stan!
Just a few quesstion:
- Are there any changes in the way we have to run tests now? Or we still run them with
python -m pytest -vvorpytest -vv? I suppose yes. - Are we introducing any dependencies? I suppose not.
- Any doc file you think needs updating? E.g., README.md, or CONTRIBUTING.md.
Thanks!
No, everything stays the same. We already had |
rturrado
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request converts the
unitteststyle tests to thepytestformat. All tests have been updated with the exception of the tests for the quantify scheduler. These tests should probably be redesigned to usequantify_schedulerinstead of mocking its behavior.Closes #215