Add ABADecomposer class #226
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change ZYZDecomposer class to be a subclass of ABADecomposer. TODO: generalise ABADecomposer.get_decomposition_angles. TODO: add XYX decomposer. TODO: add tests.
TODO: fix test_xyx_decomposer tests.
| # alpha == pi, math.tan(alpha / 2) is not defined. | ||
|
|
||
| p: float | ||
| if abs(nz) < ATOL: |
There was a problem hiding this comment.
This is still hardcoded for ny and nz angles
There was a problem hiding this comment.
In order to make it dynamic (i.e gate_list function) I feel like a similar integration to PR #98 would be required.
There was a problem hiding this comment.
Hi @juanboschero, this was my original PR. If you read the description, it says that it simply introduces the ABADecomposer, but then you have to generalize the get_decomposition_angles method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ABADecomposer class.
Change XYXDecomposer and ZYZDecomposer classes to subclass from ABADecomposer.
TODO: generalise ABADecomposer.get_decomposition_angles.
TODO: fix test_xyx_decomposer tests.