Add cQASM Lite writer #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a test_measurement to test "cQASM Lite" doesn't write 'bits' out. Move writers out of 'exporter' folder and onto 'writer' folder. Fix a typo in the Quantify Scheduler exporter.
The measure objects now have the qubit argument in first place now.
elenbaasc
approved these changes
Jun 24, 2024
There was a problem hiding this comment.
Apart from the fact that we might want to add tests to the test_writer with input circuits that have bits and measurements and that these are 'preserved' as expected, I think it should be fine. (Also, because these tests are already part of other tests as well, they might not be strictly necessary for now.)
So, nice work! Great that we could finish this today 😄
|
Thanks! Yes, I didn't add them because we didn't have them previously, let's say, and as you point, the writer is well exercised, for example, in the integration tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
cqasm_lite_writerto write out "cQASM Lite" code (cQASM 3.-beta1 code without 'bits' references).