Make opensquirrel compatible with numpy 2.0 #250
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanboschero
previously approved these changes
Jul 8, 2024
|
We have a ticket to check what is required (and what the consequences will be) to update to numpy 2.0. We will pick up these changes when we tackle that. |
elenbaasc
requested review from
juanboschero
and removed request for
juanboschero and
rturrado
Nice! Note even without numpy 2.0 support these changes can be worthwhile as they replace methods that are also deprecated in nump 1.26.x |
rturrado
previously approved these changes
Jul 17, 2024
S-Linde
previously approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace numpy deprecated (and in numpy 2.0 removed) functionality with modern numpy options