Conversation
Collaborator
elenbaasc
commented
Dec 12, 2024
elenbaasc
commented
- Restore SGMQ notation for barrier links.
- Add tests for barrier links.
- Add CHANGELOG (and entry).
Add tests for barrier links.
rturrado
reviewed
Dec 13, 2024
Contributor
rturrado
left a comment
rturrado
left a comment
There was a problem hiding this comment.
Beautiful work. Just some minor comments.
Co-authored-by: Roberto Turrado Camblor <rturrado@gmail.com>
Co-authored-by: Roberto Turrado Camblor <rturrado@gmail.com>
Co-authored-by: Roberto Turrado Camblor <rturrado@gmail.com>
rturrado
suggested changes
Dec 13, 2024
Contributor
rturrado
left a comment
rturrado
left a comment
There was a problem hiding this comment.
I have suggested merging the barrier groups as a post processing, in order to keep the visitor as clean as possible.
Co-authored-by: Roberto Turrado Camblor <rturrado@gmail.com>
Co-authored-by: Roberto Turrado Camblor <rturrado@gmail.com>
Co-authored-by: Roberto Turrado Camblor <rturrado@gmail.com>
Co-authored-by: Roberto Turrado Camblor <rturrado@gmail.com>
rturrado
reviewed
Jan 9, 2025
Contributor
rturrado
left a comment
rturrado
left a comment
There was a problem hiding this comment.
I've added a couple of comments.
Co-authored-by: Roberto Turrado Camblor <rturrado@gmail.com>
Co-authored-by: Roberto Turrado Camblor <rturrado@gmail.com>
Add test to check for double digit registers. Reinstate removing trailing lines and leaving one as the final step.
rturrado
reviewed
Jan 13, 2025
Co-authored-by: Roberto Turrado Camblor <rturrado@gmail.com>
rturrado
reviewed
Jan 13, 2025
Co-authored-by: Roberto Turrado Camblor <rturrado@gmail.com>
rturrado
reviewed
Jan 13, 2025
Co-authored-by: Roberto Turrado Camblor <rturrado@gmail.com>
Co-authored-by: Roberto Turrado Camblor <rturrado@gmail.com>
rturrado
reviewed
Jan 14, 2025
rturrado
approved these changes
Jan 15, 2025
elenbaasc
deleted the
CQT-259-Integrate-wait-and-barrier-directives-in-cQASMv1-exporter
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.