Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CQT-259] Integrate wait and barrier directives in cQASMv1 exporter #407

Merged
merged 23 commits into from
Jan 21, 2025
Merged

[CQT-259] Integrate wait and barrier directives in cQASMv1 exporter #407

merged 23 commits into from
Jan 21, 2025

Conversation

elenbaasc
Copy link
Collaborator

  • Restore SGMQ notation for barrier links.
  • Add tests for barrier links.
  • Add CHANGELOG (and entry).

@elenbaasc
Restore SGMQ notation for barrier links.
38ce5b7 
Add tests for barrier links.
rturrado
rturrado reviewed Dec 13, 2024
View reviewed changes
Copy link
Contributor

@rturrado rturrado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful work. Just some minor comments.

elenbaasc and others added 4 commits December 13, 2024 14:20
@elenbaasc @rturrado
Update CHANGELOG.md
f4cbfde 
Co-authored-by: Roberto Turrado Camblor <rturrado@gmail.com>
@elenbaasc @rturrado
Update opensquirrel/passes/exporter/cqasmv1_exporter.py
2f6fb2a 
Co-authored-by: Roberto Turrado Camblor <rturrado@gmail.com>
@elenbaasc @rturrado
Update test/exporter/test_cqasmv1_exporter.py
4cc918b 
Co-authored-by: Roberto Turrado Camblor <rturrado@gmail.com>
@elenbaasc
Resolve review comments.
30ff3b1
rturrado
rturrado requested changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@rturrado rturrado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have suggested merging the barrier groups as a post processing, in order to keep the visitor as clean as possible.

elenbaasc and others added 7 commits December 16, 2024 10:53
@elenbaasc @rturrado
Update opensquirrel/passes/exporter/cqasmv1_exporter.py
70f8ab9 
Co-authored-by: Roberto Turrado Camblor <rturrado@gmail.com>
@elenbaasc @rturrado
Update test/exporter/test_cqasmv1_exporter.py
7d95bad 
Co-authored-by: Roberto Turrado Camblor <rturrado@gmail.com>
@elenbaasc @rturrado
Update test/exporter/test_cqasmv1_exporter.py
d864fcc 
Co-authored-by: Roberto Turrado Camblor <rturrado@gmail.com>
@elenbaasc @rturrado
Update test/exporter/test_cqasmv1_exporter.py
43f3560 
Co-authored-by: Roberto Turrado Camblor <rturrado@gmail.com>
@elenbaasc
Merge develop into CQT-259
c0c15ee
@elenbaasc
Revert changes to cQASMv1 exporter and comment barrier tests.
3e3c559
@elenbaasc
Implement barrier grouping as post-processing step
c226368
rturrado
rturrado reviewed Jan 9, 2025
View reviewed changes
Copy link
Contributor

@rturrado rturrado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a couple of comments.

elenbaasc and others added 4 commits January 10, 2025 09:52
@elenbaasc @rturrado
Update opensquirrel/passes/exporter/cqasmv1_exporter.py
56827a9 
Co-authored-by: Roberto Turrado Camblor <rturrado@gmail.com>
@elenbaasc @rturrado
Update opensquirrel/passes/exporter/cqasmv1_exporter.py
d4b7b28 
Co-authored-by: Roberto Turrado Camblor <rturrado@gmail.com>
@elenbaasc
Fix regex module.
0c70f25 
Add test to check for double digit registers.
Reinstate removing trailing lines and leaving one as the final step.
@elenbaasc
Revert actions-poetry from v4 to v3 so the pipeline can run.
7976aab
@elenbaasc elenbaasc requested a review from rturrado January 10, 2025 10:37
rturrado
rturrado reviewed Jan 13, 2025
View reviewed changes
@elenbaasc @rturrado
Update CHANGELOG.md
9e9bec7 
Co-authored-by: Roberto Turrado Camblor <rturrado@gmail.com>
@elenbaasc elenbaasc requested a review from rturrado January 13, 2025 15:08
rturrado
rturrado reviewed Jan 13, 2025
View reviewed changes
@elenbaasc @rturrado
Update CHANGELOG.md
4989b3e 
Co-authored-by: Roberto Turrado Camblor <rturrado@gmail.com>
@elenbaasc elenbaasc requested a review from rturrado January 13, 2025 15:33
elenbaasc and others added 2 commits January 14, 2025 10:13
@elenbaasc @rturrado
Update opensquirrel/passes/exporter/cqasmv1_exporter.py
d9577fb 
Co-authored-by: Roberto Turrado Camblor <rturrado@gmail.com>
@elenbaasc @rturrado
Update opensquirrel/passes/exporter/cqasmv1_exporter.py
580604b 
Co-authored-by: Roberto Turrado Camblor <rturrado@gmail.com>
@elenbaasc elenbaasc requested a review from rturrado January 14, 2025 09:14
@elenbaasc elenbaasc merged commit 961f903 into develop Jan 21, 2025
15 checks passed
@elenbaasc elenbaasc deleted the CQT-259-Integrate-wait-and-barrier-directives-in-cQASMv1-exporter branch January 21, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rturrado rturrado rturrado approved these changes

@GuyPuts GuyPuts Awaiting requested review from GuyPuts

@juanboschero juanboschero Awaiting requested review from juanboschero

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elenbaasc @rturrado