Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CQT-266] Routing checker pass #411

Merged
merged 10 commits into from
Jan 15, 2025
Merged

[CQT-266] Routing checker pass #411

merged 10 commits into from
Jan 15, 2025

Conversation

rares1609
Copy link
Contributor

Added a Routing Checker pass

@rturrado rturrado changed the title Cqt 266 routing checker pass [CQT-266] Routing checker pass Dec 19, 2024
elenbaasc
elenbaasc reviewed Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@elenbaasc elenbaasc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks for the effort!

Main point is that the qubit interactions should be inferred from the circuit, rather than providing them as user input. But close to be done I would say.

opensquirrel/circuit.py Outdated Show resolved Hide resolved
opensquirrel/passes/router/general_router.py Outdated Show resolved Hide resolved
opensquirrel/passes/router/routing_checker.py Outdated Show resolved Hide resolved
opensquirrel/passes/router/routing_checker.py Outdated Show resolved Hide resolved
opensquirrel/passes/router/routing_checker.py Outdated Show resolved Hide resolved
test/router/test_routing_checker.py Outdated Show resolved Hide resolved
test/router/test_routing_checker.py Outdated Show resolved Hide resolved
test/router/test_routing_checker.py Outdated Show resolved Hide resolved
test/test_integration.py Outdated Show resolved Hide resolved
@elenbaasc elenbaasc self-requested a review January 15, 2025 11:00
elenbaasc
elenbaasc approved these changes Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@elenbaasc elenbaasc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for making the changes!

When merging, make sure to use the option: Squash and merge

@rares1609 rares1609 merged commit 231268c into develop Jan 15, 2025
15 checks passed
@rares1609 rares1609 deleted the CQT-266-Routing-checker-pass branch January 15, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elenbaasc elenbaasc elenbaasc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rares1609 @elenbaasc