[CQT-293] Remove generators #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change default gate modifiers from callables to classes. Move default instructions and default gate modifiers to IR. Remove generators from IR instructions. Remove ANNOTATIONS_TO_TYPE_MAP. Remove instruction decorators. Remove instruction_library.py. Pass all tests except for test_gate_modifiers. Pass format and ruff check --fix linters. TODO: - Rewrite parser.py using instruction_generator. - Pass gate modifiers tests.
Change default gate modifiers back from IR nodes to functors. Add inv.inv.X gate modifier test. Pass all tests. Pass format and ruff check --fix linters.
Rewrite test_anonymous_gate test in test_tutorial.py. Pass all linters.
rturrado
requested review from
elenbaasc,
S-Linde,
juanboschero,
GuyPuts and
rares1609
elenbaasc
reviewed
Jan 24, 2025
# Conflicts: # opensquirrel/default_instructions.py # opensquirrel/ir.py # opensquirrel/parser/libqasm/parser.py # opensquirrel/passes/exporter/cqasmv1_exporter.py # opensquirrel/passes/merger/general_merger.py # opensquirrel/utils/matrix_expander.py # opensquirrel/writer/writer.py # test/docs/test_tutorial.py # test/test_circuit_builder.py
…CQT-293-Remove-generators
Rename BsrWithAngleParm to BsrAngleParam.
Remove Gate::is_anonymous property.
elenbaasc
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Must read
This PR is mainly an investigation, although offering already a working implementation as a proof of concept. As such, I would advise to read first the Confluence page, and then use the PR as a companion to see the implementation changes.
Changes
This PR includes also other changes and fixes (some of which may not be detailed in the Confluence page):
acceptimplementation of the IR node classes.try_match_replace_with_default(oldtry_name_anonymous_gate) work with Rx, Ry, and Rz, e.g., Rx(pi/4) 4 times gives now Rx(pi), and not an anoymous Bloch.inv.inv.Xis now an X, not anonymous anymore.Change log