Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in writer for SWAP instruction. #444

Merged
merged 6 commits into from
Jan 31, 2025
Merged

Fix bug in writer for SWAP instruction. #444

merged 6 commits into from
Jan 31, 2025

Conversation

elenbaasc
Copy link
Collaborator

  • Added "qubit0" and "qubit1" to the qubit_function_keys
  • Added test to check if SWAP is properly writen

@elenbaasc elenbaasc requested a review from rturrado January 31, 2025 11:04
@elenbaasc
Add CHANGELOG entry.
adff860 
Update OpenSquirrel version number.
rturrado
rturrado reviewed Jan 31, 2025
View reviewed changes
Copy link
Contributor

@rturrado rturrado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really wish we have the 'Remove generators' PR in soon.

CHANGELOG.md Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@elenbaasc @rturrado
Update CHANGELOG.md
fb22fb8 
Co-authored-by: Roberto Turrado Camblor <rturrado@gmail.com>
@elenbaasc
Copy link
Collaborator Author

I really wish we have the 'Remove generators' PR in soon.

I had put my review comments already a while ago and assigned you. Didn't realize you were just waiting...

@elenbaasc elenbaasc requested a review from rturrado January 31, 2025 12:28
@rturrado
Copy link
Contributor

I had put my review comments already a while ago and assigned you. Didn't realize you were just waiting...

No, no, I'm not. I was just busy with QX. Not blaming you for stopping that PR or something! 😀

rturrado
rturrado reviewed Jan 31, 2025
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
elenbaasc and others added 2 commits January 31, 2025 14:26
@elenbaasc
Copy link
Collaborator Author

I had put my review comments already a while ago and assigned you. Didn't realize you were just waiting...

No, no, I'm not. I was just busy with QX. Not blaming you for stopping that PR or something! 😀

Ah, oke, ... it does not have priority, but the refactor would be nice to have soon, and indeed will become more and more tricky while we add new things in the meantime (also this bugfix wouldn't have been necessary).

@elenbaasc elenbaasc merged commit 07e1ee2 into develop Jan 31, 2025
15 checks passed
@elenbaasc elenbaasc deleted the CQT-319-Bug-in-writing-SWAP-arguments branch January 31, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rturrado rturrado rturrado approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elenbaasc @rturrado