Merged
Conversation
Update get_gate_arguments to accept lists of parameters. Add general test for all supported instructions.
elenbaasc
commented
Mar 31, 2025
Collaborator
Author
There was a problem hiding this comment.
Thanks! If you have no comments or require any further changes you can always immediately 'Approve' 😄
rares1609
reviewed
Mar 31, 2025
Contributor
rares1609
left a comment
rares1609
left a comment
There was a problem hiding this comment.
This issue looks great! The Rn gate was added to the IR of OpenSquirrel and other relevant files, and it seems to follow the characteristics mentioned in the documentation.
There is only one thing left to add: updating the changelog file :).
rares1609
previously approved these changes
Mar 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_get_expanded_instruction_argsinparser.pyto accept lists of parameterstest_instructions.py)