Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create merge pass #75

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Create merge pass #75

merged 1 commit into from
Feb 6, 2024

Conversation

pablolh
Copy link

@pablolh pablolh commented Jan 25, 2024

  • Circuit.merge_single_qubit_gates
  • mcKay decomposer is now only the decomposition
  • Circuit.decompose is introduced, pass it the McKay decomposer

@pablolh pablolh force-pushed the 63-create-1-qubit-generic-fusion-pass branch 2 times, most recently from 4eb6ff5 to 944320a Compare January 25, 2024 16:12
@pablolh pablolh requested a review from elenbaasc January 25, 2024 16:19
@pablolh pablolh force-pushed the 63-create-1-qubit-generic-fusion-pass branch from 944320a to f5fa9f7 Compare January 29, 2024 16:45
@pablolh
Copy link
Author

pablolh commented Jan 29, 2024

I just added checks to make sure every decomposition keeps the circuit matrix! With tests of course

@pablolh pablolh force-pushed the 63-create-1-qubit-generic-fusion-pass branch from f5fa9f7 to d3c4478 Compare January 31, 2024 15:19
elenbaasc
elenbaasc reviewed Feb 1, 2024
View reviewed changes
opensquirrel/circuit.py Outdated Show resolved Hide resolved
opensquirrel/circuit.py Outdated Show resolved Hide resolved
opensquirrel/circuit.py Outdated Show resolved Hide resolved
opensquirrel/common.py Outdated Show resolved Hide resolved
opensquirrel/mckay_decomposer.py Outdated Show resolved Hide resolved
opensquirrel/replacer.py Outdated Show resolved Hide resolved
opensquirrel/replacer.py Show resolved Hide resolved
opensquirrel/squirrel_ir.py Show resolved Hide resolved
opensquirrel/squirrel_ir.py Outdated Show resolved Hide resolved
test/test_mckay_decomposer.py Outdated Show resolved Hide resolved
@pablolh pablolh force-pushed the 63-create-1-qubit-generic-fusion-pass branch 2 times, most recently from 09033af to 9e59243 Compare February 5, 2024 11:04
Create merge pass
304a4cd 
- Circuit.merge_single_qubit_gates
- mcKay decomposer is now only the decomposition
- Circuit.decompose is introduced, pass it the McKay decomposer
- Decomposer abstract base class
- The decomposer/replacer now checks that every used decomposition is
  valid in terms of circuit matrix!
@pablolh pablolh force-pushed the 63-create-1-qubit-generic-fusion-pass branch from 9e59243 to 304a4cd Compare February 6, 2024 13:19
@pablolh pablolh merged commit 00821a8 into develop Feb 6, 2024
17 checks passed
@elenbaasc elenbaasc deleted the 63-create-1-qubit-generic-fusion-pass branch April 9, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elenbaasc elenbaasc elenbaasc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pablolh @elenbaasc