Move MIS sampler into backend implementation #705
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Description
perceval/algorithm/mis.pyand stop exportingMISfrom thealgorithmpackage.perceval/backends/_mis.pyimplementingMISBackendthat builds a distinguishable-photon proposal from|U|^2, applies MIS acceptance using exact probabilities from theSLOSbackend, and supportsburn_inandseedparameters.MISBackendtoBACKEND_LISTand exposing it under the name"MIS"inperceval/backends/__init__.pyso it can be created viaBackendFactory.get_backend("MIS", ...)orProcessor("MIS", ...).MISBackenddelegates target probability evaluation to the existingSLOSBackendrather than embedding verification code.Testing
BACKEND_LISTupdated) but no unit or integration tests were run.MISBackend.samples/sampleand integration tests exercisingProcessor("MIS")in a follow-up PR.Codex Task