PCVL-1136 perceval integration with qaptiva #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AliseeNguyen
reviewed
Dec 9, 2025
| BSDistribution, FockState | ||
| BSDistribution, FockState, ProviderFactory, BSSamples | ||
| from perceval.algorithm import Sampler | ||
| from perceval.runtime.rpc_handler import RPCHandler |
Collaborator
There was a problem hiding this comment.
you don't use the RPCHandler class you just created ?
Collaborator
Author
There was a problem hiding this comment.
I don't need it, this RPCHandler is purely for the internal behaviour of a RemoteProcessor created by the MyQML session. A user should not use it, nor even know that it exists.
| """ | ||
| payload["platform_name"] = "" # Needed to make the QPUHandler happy | ||
| my_qlm_job = MyQLMHelper.make_job_from_payload(payload) | ||
| job_id = str(self._job_id) |
Collaborator
There was a problem hiding this comment.
I think these 2 lines (70-71) are not secured, there can be 2 calls from 2 different instances of RPCHandler at the same time and they can get the same value for _job_id
AliseeNguyen
approved these changes
Dec 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.