Skip to content

Conversation

Romazes
Copy link
Collaborator

@Romazes Romazes commented Sep 30, 2025

Description

Refactored the abstract class BrokerageTests to extend support for combo order types. The refactor allows developers to leverage generic test cases from Lean for their brokerage consumers, enabling independent testing of order logic.

Related Issue

N/A

Related PRs

Motivation and Context

Previously, BrokerageTests had limited support for testing different order types, making it cumbersome for developers to validate combo orders in their custom brokerage implementations. This refactor streamlines the process, improving test coverage and reducing boilerplate code.

Requires Documentation Change

N/A

How Has This Been Tested?

  • Verified that existing single order type tests continue to pass. (I have test in InteractiveBrokers)
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

@Romazes Romazes self-assigned this Sep 30, 2025
Copy link
Member

@Martin-Molinero Martin-Molinero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

test:rename: method in ComboOrderTestParameters
test:remove: duplication
@Romazes Romazes merged commit 3f8fd6a into QuantConnect:master Oct 6, 2025
8 checks passed
AlexCatarino added a commit to QuantConnect/Documentation that referenced this pull request Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants