-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Feature: support ComboLimit
Order type in TastyTrade and refactor BrokerageTests
#9003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Romazes
merged 25 commits into
QuantConnect:master
from
Romazes:feature-support-new-order-type-tastytrade
Oct 6, 2025
Merged
Feature: support ComboLimit
Order type in TastyTrade and refactor BrokerageTests
#9003
Romazes
merged 25 commits into
QuantConnect:master
from
Romazes:feature-support-new-order-type-tastytrade
Oct 6, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: comboOrderTestParameters feat: tastytrade option strategy algo
feat: ComboLimitOrderTestParameters
test:feat: submit combo limit cross zero test cases in tastytrade
feat: overload GreatestCommonDivisor test:feat: GetGroupQuantityByEachLegQuantity
This reverts commit 4f92f97.
Martin-Molinero
approved these changes
Oct 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
test:rename: method in ComboOrderTestParameters test:remove: duplication
Martin-Molinero
approved these changes
Oct 6, 2025
AlexCatarino
added a commit
to QuantConnect/Documentation
that referenced
this pull request
Oct 6, 2025
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactored the
abstract class BrokerageTests
to extend support for combo order types. The refactor allows developers to leverage generic test cases from Lean for their brokerage consumers, enabling independent testing of order logic.Related Issue
N/A
Related PRs
ComboLimitOrder
Lean.Brokerages.Tastytrade#13Motivation and Context
Previously,
BrokerageTests
had limited support for testing different order types, making it cumbersome for developers to validate combo orders in their custom brokerage implementations. This refactor streamlines the process, improving test coverage and reducing boilerplate code.Requires Documentation Change
N/A
How Has This Been Tested?
Types of changes
Checklist:
bug-<issue#>-<description>
orfeature-<issue#>-<description>