Skip to content

[mle] Update JAX code to latest version #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[mle] Update JAX code to latest version #232

wants to merge 3 commits into from

Conversation

kp992
Copy link
Contributor

@kp992 kp992 commented Aug 30, 2025

This PR:

  • Updates the JAX code to latest APIs. JAX now supports factorial.
  • Fixes typos and math errors.

@netlify Netlify
Copy link

netlify bot commented Aug 30, 2025 •
edited
Loading

✅ Deploy Preview for incomparable-parfait-2417f8 ready!

Name Link
🔨 Latest commit fc7c6f5
🔍 Latest deploy log https://app.netlify.com/projects/incomparable-parfait-2417f8/deploys/68b26942353d8e00083c5a11
😎 Deploy Preview https://deploy-preview-232--incomparable-parfait-2417f8.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 30, 2025 •
edited
Loading

🚀 Deployed on https://68b26dc492f982659f1b3138--incomparable-parfait-2417f8.netlify.app

@github-actions github-actions bot temporarily deployed to pull request August 30, 2025 03:15 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 30, 2025 03:19 Inactive
@kp992 kp992 requested review from HumphreyYang and mmcky September 2, 2025 23:19
@kp992 kp992 mentioned this pull request Sep 2, 2025
Open
HumphreyYang
HumphreyYang approved these changes Sep 15, 2025
View reviewed changes
Copy link
Member

@HumphreyYang HumphreyYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks @kp992.

Hi @mmcky, I am curious if we should always migrate changes / fixes to the lectures in the JAX series since we are incorprating them into the intermediate series now.

@kp992
Copy link
Contributor Author

kp992 commented Sep 15, 2025

Thanks @HumphreyYang I am trying to make sure to migrate the changes in parallel so that we keep both the series up-to-date and avoid re-visiting them again in JAX.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HumphreyYang HumphreyYang HumphreyYang approved these changes

@mmcky mmcky Awaiting requested review from mmcky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kp992 @HumphreyYang