Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: enable .jupyter_cache to be included in cache runs #329

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Conversation

mmcky
Copy link
Contributor

@mmcky mmcky commented Nov 4, 2024

This PR fixes a bug that has prevented the cache mechanism to work.

Hidden files were not included by default in the upload-artifact action

https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md#hidden-files

Copy link

github-actions bot commented Nov 4, 2024

@github-actions github-actions bot temporarily deployed to pull request November 4, 2024 03:28 Inactive
@mmcky mmcky merged commit a0fa8c6 into main Nov 4, 2024
5 of 6 checks passed
@mmcky mmcky deleted the maint-04nov branch November 4, 2024 03:28
@kp992
Copy link

kp992 commented Nov 4, 2024

Oh, this looks great. Nice catch!

But I am wondering why it wasn't failing 2-3 months ago

@kp992
Copy link

kp992 commented Nov 4, 2024

I see, it is because of this: https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md#hidden-files. The version change of Action file is the issue. Thanks @mmcky

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants