Conversation
Contributor
Author
|
closing as no longer needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the suggestions by
ClaudeLLM for #457Notes: This has been really interesting. The suggestions by
Claudedon't take into account the flow of the program -- in Jupyter notebooks context. For example, the suggestions to update the section, come before the functionplot_saving_rateis defined causing an execution error. It also makes some assumptions thats_ssis a defined variable by passing it in -- but it is never used in the lecture.Also its solution to plotting is quite verbose, when it basically replicates the same diagram as found in the section before it.