[mccall_model] Replace np.sum(a * b) with a @ b#471
Merged
mmcky merged 1 commit intoQuantEcon:mainfrom Jul 21, 2025
UdohNakamura:UdohNakamura-patch-1
Merged
[mccall_model] Replace np.sum(a * b) with a @ b#471mmcky merged 1 commit intoQuantEcon:mainfrom UdohNakamura:UdohNakamura-patch-1
np.sum(a * b) with a @ b#471mmcky merged 1 commit intoQuantEcon:mainfrom
UdohNakamura:UdohNakamura-patch-1
Conversation
Contributor
|
thank you @UdohNakamura for this FIX - I have enabled the tests to run. |
HumphreyYang
reviewed
Jul 2, 2025
| # Consider action = accept or reject the current offer | ||
| accept = w[i] / (1 - β) | ||
| reject = c + β * np.sum(v * q) | ||
| reject = c + β * (v @ q) |
Member
There was a problem hiding this comment.
Many thanks @UdohNakamura and @mmcky,
When building on my side I got
<string>:3: NumbaPerformanceWarning: '@' is faster on contiguous arrays, called on (Array(float64, 1, 'C', False, aligned=True), Array(float64, 1, 'A', False, aligned=True))
Upon checking, I found we annotate the type
('w', float64[:]), # array of wage values, w[i] = wage at state i
('q', float64[:]) # array of probabilities
The following type will help (see more here:
('w', float64[::1]), # array of wage values, w[i] = wage at state i
('q', float64[::1]) # array of probabilities
Please let me know what you think.
Member
There was a problem hiding this comment.
@HumphreyYang Thanks, I didn't know that. Maybe write float64[::1] in place of float64[:] and explain that it is needed to have @ work inside a jitclass?
Contributor
There was a problem hiding this comment.
thanks @HumphreyYang and @oyamad
@HumphreyYang I will merge these great PRs and then you can do a pass to fix this.
mmcky
approved these changes
Jul 21, 2025
Contributor
|
thanks so much of this PR @UdohNakamura |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
np.sum(a * b)witha @ b#463