Skip to content

TEST: Theme PR #319 - Optional Custom Code Style Feature#666

Closed
mmcky wants to merge 5 commits intomainfrom
test-theme-pr319
Closed

TEST: Theme PR #319 - Optional Custom Code Style Feature#666
mmcky wants to merge 5 commits intomainfrom
test-theme-pr319

Conversation

@mmcky
Copy link
Contributor

@mmcky mmcky commented Nov 2, 2025

This PR tests the new theme feature from QuantEcon/quantecon-book-theme#319

Changes

  • Updates environment.yml to install quantecon-book-theme from the feature/optional-custom-code-style branch
  • Tests the new optional custom code style feature

Purpose

Testing the theme changes in CI to ensure compatibility with the lecture materials before merging the theme PR.

Related

@github-actions
Copy link

github-actions bot commented Nov 2, 2025

📖 Netlify Preview Ready!

Preview URL: https://pr-666--sunny-cactus-210e3e.netlify.app (5668c16)

@mmcky
Copy link
Contributor Author

mmcky commented Nov 2, 2025

An example of the updated qetheme_custom_style with no italic on python docstrings.

Screenshot 2025-11-03 at 8 44 31 am

@mmcky
Copy link
Contributor Author

mmcky commented Nov 2, 2025

Here is the colourful pygments_style

Screenshot 2025-11-03 at 8 49 30 am

and applied to QuantEcon lecture likelihood_ratio_processes:

Screenshot 2025-11-03 at 10 25 44 am

@mmcky
Copy link
Contributor Author

mmcky commented Nov 2, 2025

Here is the vs pygments style

Screenshot 2025-11-03 at 8 51 51 am

and applied to QuantEcon lecture likelihood_ratio_processes:

Screenshot 2025-11-03 at 10 28 08 am

@github-actions
Copy link

github-actions bot commented Nov 2, 2025

📖 Netlify Preview Ready!

Preview URL: https://pr-666--sunny-cactus-210e3e.netlify.app (3501d93)

@github-actions
Copy link

github-actions bot commented Nov 2, 2025

📖 Netlify Preview Ready!

Preview URL: https://pr-666--sunny-cactus-210e3e.netlify.app (06f55f4)

@github-actions
Copy link

github-actions bot commented Nov 2, 2025

📖 Netlify Preview Ready!

Preview URL: https://pr-666--sunny-cactus-210e3e.netlify.app (e03ce30)

@mmcky
Copy link
Contributor Author

mmcky commented Nov 3, 2025

Here is a comparison between default and vs for a typical function:

pygments: vs qetheme
Screenshot 2025-11-03 at 11 04 11 am Screenshot 2025-11-03 at 11 04 28 am

the only downside of vs is the text is no longer qetheme blue.

So we could just stick with our colours (and the removed italic update).

@github-actions
Copy link

github-actions bot commented Nov 3, 2025

📖 Netlify Preview Ready!

Preview URL: https://pr-666--sunny-cactus-210e3e.netlify.app (5966f1f)

@mmcky
Copy link
Contributor Author

mmcky commented Nov 3, 2025

Closing as no longer required.

@mmcky mmcky closed this Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant