Fix transpose_matvec for categorical matrix with read-only indices (replaces #489) #491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paolamalsot
requested review from
MarcAntoineSchmidtQC,
jtilly and
stanmart
as code owners
Collaborator
|
Can you pls revert dc1cb71? That was just for interactive testing. |
1 task
This reverts commit dc1cb71.
stanmart
approved these changes
Oct 27, 2025
Collaborator
stanmart
left a comment
stanmart
left a comment
There was a problem hiding this comment.
Thank you for fixing this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces #489.
The previous PR introduced a test case (1ffcc26) and an initial fix (14c7553), but @jtilly suggested a cleaner implementation (d608d50).
This PR applies @jtilly’s improved fix while keeping the test from the original PR. All tests now pass.
Checklist
CHANGELOG.rstentry