Skip to content

chore+docs: strict ruff linting#349

Draft
philipp-seitz wants to merge 26 commits intomainfrom
docs/docstrings
Draft

chore+docs: strict ruff linting#349
philipp-seitz wants to merge 26 commits intomainfrom
docs/docstrings

Conversation

@philipp-seitz
Copy link
Collaborator

uv run ruff check --config tierkreis/pyproject.toml tierkreis --output-format=concise
now yields only 35 problems, I'm not super confident in changing them

tierkreis/tierkreis/builder.py:225:11: TD003 Missing issue link for this TODO
tierkreis/tierkreis/builder.py:225:11: FIX002 Line contains TODO, consider resolving the issue
tierkreis/tierkreis/controller/__init__.py:31:5: PLR0913 Too many arguments in function definition (7 > 5)
tierkreis/tierkreis/controller/__init__.py:124:15: TD002 Missing author in TODO; try: `# TODO(<author_name>): ...` or `# TODO @<author_name>: ...`
tierkreis/tierkreis/controller/__init__.py:124:15: TD003 Missing issue link for this TODO
tierkreis/tierkreis/controller/__init__.py:124:15: FIX002 Line contains TODO, consider resolving the issue
tierkreis/tierkreis/controller/data/models.py:41:5: D103 Missing docstring in public function
tierkreis/tierkreis/controller/data/models.py:51:7: D101 Missing docstring in public class
tierkreis/tierkreis/controller/data/models.py:55:9: D102 Missing docstring in public method
tierkreis/tierkreis/controller/data/models.py:78:5: D103 Missing docstring in public function
tierkreis/tierkreis/controller/data/models.py:92:5: D103 Missing docstring in public function
tierkreis/tierkreis/controller/data/models.py:99:5: D103 Missing docstring in public function
tierkreis/tierkreis/controller/data/models.py:106:5: D103 Missing docstring in public function
tierkreis/tierkreis/controller/data/models.py:114:5: D103 Missing docstring in public function
tierkreis/tierkreis/controller/data/models.py:121:5: D103 Missing docstring in public function
tierkreis/tierkreis/controller/data/models.py:131:5: D103 Missing docstring in public function
tierkreis/tierkreis/controller/data/models.py:146:5: D103 Missing docstring in public function
tierkreis/tierkreis/controller/data/types.py:236:5: C901 `ser_from_ptype` is too complex (12 > 10)
tierkreis/tierkreis/controller/data/types.py:236:5: PLR0911 Too many return statements (11 > 6)
tierkreis/tierkreis/controller/data/types.py:298:5: C901 `coerce_from_annotation` is too complex (23 > 10)
tierkreis/tierkreis/controller/data/types.py:298:5: PLR0911 Too many return statements (16 > 6)
tierkreis/tierkreis/controller/data/types.py:298:5: PLR0912 Too many branches (22 > 12)
tierkreis/tierkreis/controller/data/types.py:359:16: S301 `pickle` and modules that wrap it can be unsafe when used to deserialize untrusted data, possible security issue
tierkreis/tierkreis/controller/executor/hpc/slurm.py:65:16: TD003 Missing issue link for this TODO
tierkreis/tierkreis/controller/executor/hpc/slurm.py:65:16: FIX002 Line contains TODO, consider resolving the issue
tierkreis/tierkreis/controller/start.py:84:5: C901 `start` is too complex (17 > 10)
tierkreis/tierkreis/controller/start.py:84:5: PLR0912 Too many branches (19 > 12)
tierkreis/tierkreis/controller/start.py:84:5: PLR0915 Too many statements (64 > 50)
tierkreis/tierkreis/controller/storage/filestorage.py:43:26: S108 Probable insecure usage of temporary file or directory: "/tmp/"
tierkreis/tierkreis/controller/storage/walk.py:95:5: C901 `walk_node` is too complex (14 > 10)
tierkreis/tierkreis/controller/storage/walk.py:95:5: PLR0911 Too many return statements (13 > 6)
tierkreis/tierkreis/controller/storage/walk.py:95:5: PLR0912 Too many branches (14 > 12)
tierkreis/tierkreis/graphs/fold.py:103:7: TD003 Missing issue link for this TODO
tierkreis/tierkreis/graphs/fold.py:103:7: FIX002 Line contains TODO, consider resolving the issue
tierkreis/tierkreis/worker/storage/filestorage.py:53:16: PTH207 Replace `glob` with `Path.glob` or `Path.rglob`

@philipp-seitz philipp-seitz requested review from johnchildren and mwpb and removed request for mwpb February 24, 2026 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant