Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name = "Strided"
uuid = "5e0ebb24-38b0-5f93-81fe-25c709ecae67"
version = "2.3.4"
version = "2.3.5"
authors = ["Lukas Devos <lukas.devos@ugent.be>", "Maarten Van Damme <maartenvd1994@gmail.com>", "Jutho Haegeman <jutho.haegeman@ugent.be>"]

[deps]
Expand Down
7 changes: 5 additions & 2 deletions src/broadcast.jl
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,16 @@ Base.dotview(a::StridedView{<:Any, N}, I::Vararg{SliceIndex, N}) where {N} = get
dest::StridedView{<:Any, N},
bc::Broadcasted{StridedArrayStyle{N}}
) where {N}
dims = size(dest)
any(isequal(0), dims) && return dest

# convert to map

# flatten and only keep the StridedView arguments
# promote StridedView to have same size, by giving artificial zero strides
stridedargs = promoteshape(size(dest), capturestridedargs(bc)...)
stridedargs = promoteshape(dims, capturestridedargs(bc)...)
c = make_capture(bc)
_mapreduce_fuse!(c, nothing, nothing, size(dest), (dest, stridedargs...))
_mapreduce_fuse!(c, nothing, nothing, dims, (dest, stridedargs...))
return dest
end

Expand Down
8 changes: 8 additions & 0 deletions test/othertests.jl
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,14 @@ end
end
end

@testset "broadcast with zero-length StridedView" begin
@testset for T in (Float32, Float64, ComplexF32, ComplexF64)
A1 = StridedView(zeros(T, (2, 0)))
A2 = StridedView(zeros(T, (2, 0)))
@test (A1 .+ A2) == StridedView(zeros(T, (2, 0)))
end
end

@testset "mapreduce with StridedView" begin
@testset for T in (Float32, Float64, ComplexF32, ComplexF64)
R1 = rand(T, (10, 10, 10, 10, 10, 10))
Expand Down
Loading