Conversation
chernishev
reviewed
Nov 13, 2025
src/sort_list.c
Outdated
| #include<stdio.h> | ||
| #include<stdlib.h> | ||
| #include<stdbool.h> | ||
| typedef struct sort_list{ |
Collaborator
There was a problem hiding this comment.
надо бы переносов строк добавить, а то нечитабельно
chernishev
reviewed
Nov 13, 2025
src/sort_list.c
Outdated
| struct sort_list *next; | ||
| } sort_list; | ||
| void append(sort_list *begin, int value){ | ||
| sort_list *new_elem = malloc(sizeof(sort_list)); |
Collaborator
There was a problem hiding this comment.
все системные функции проверяем на возвращаемое значение. всегда и везде; поправьте
chernishev
reviewed
Nov 13, 2025
src/sort_list.c
Outdated
| bool flag = 0; | ||
| new_elem->value = value; | ||
| while (p->next != NULL){ | ||
| if (p->next->value > value){ |
Collaborator
There was a problem hiding this comment.
починить везде в программе
chernishev
reviewed
Nov 13, 2025
src/sort_list.c
Outdated
| p->next = new_elem; | ||
| } | ||
| } | ||
| void del_elem(sort_list *begin, int value){ |
Collaborator
There was a problem hiding this comment.
chernishev
requested changes
Nov 13, 2025
Collaborator
chernishev
left a comment
chernishev
left a comment
There was a problem hiding this comment.
5/6 замечания в коде
p-senichenkov
approved these changes
Dec 25, 2025
p-senichenkov
approved these changes
Dec 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.