Fixing typing issues and adding new support #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixing the typing error on create_form seems like a good idea to me. @crood58 / @quartlover Would you be open to merging this? Happy to help fix conflicts or open a more limited PR if it'd be helpful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's great to see the efforts that have gone into typing in Quart-WTF so far, but there is a bit more polishing that can be done. Primarily, I started this PR because QuartForm's create_form returned specifically an instance of QuartForm, not the correct class instance. My solution uses typing_extentions, which is already required by Quart anyways, and won't be adding a dependency for the vast majority of projects. I also took a shot at resolving any other typing issues I could find between what mypy and pyright complained about.