Do not fail on timeout for toAlways and toNever
#1192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our CI system runs on up to 4 parallel simulators, putting the CPU under higher-than-average stress levels. As a result, we get occasional flakiness when
toEventually,toAlwaysandtoNeverencounter a blocked run loop.In this scenario, it doesn't really make sense for
toAlwaysandtoNeverto fail, since the conditions weren't violated in the extended timeout window.This change addresses that issue by resolving with
.timeOutfor continousAsyncMatchStyles even when the main loop is blocked.Checklist - While not every PR needs it, new features should consider this list: