Merged
Conversation
RichLogan
requested review from
GhostofCookie,
TimEvens and
suhasHere
and removed request for
GhostofCookie
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix bug in
SUBSCRIBE_OKmessage construction, where content exists having a value of0would result in a location of{0, 0}being encoded, rather than no location at all. I have changed the API so that the type system stops a bad combo of arguments.However, I think this is a good example of how something like #607 would allow us to encode these rules that aren't otherwise parsed from the spec and catch them as early as possible in deserialize, and also as a last chance check on serialize.
Some known message vectors would also be great test suite addition - and probably a good addition as a draft appendix?