Open
Conversation
Switch `sub_tracks_by_request_id` to use `request_handlers`
RichLogan
reviewed
Feb 19, 2026
RichLogan
reviewed
Feb 19, 2026
Collaborator
Author
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f84d534de8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
GhostofCookie
approved these changes
Feb 20, 2026
Comment on lines
+426
to
+430
| TrackHandler& operator=(const TrackHandler& other) | ||
| { | ||
| handler = other.handler; | ||
| return *this; | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| TrackHandler& operator=(const TrackHandler& other) | |
| { | |
| handler = other.handler; | |
| return *this; | |
| } | |
| TrackHandler& operator=(const TrackHandler& other) = default; |
| auto sub_handler = static_cast<SubscribeTrackHandler*>(sub_it->second.handler.get()); | ||
|
|
||
| auto expires = msg.parameters.Get<std::uint64_t>(messages::ParameterType::kExpires); | ||
| if (auto sub_handler = sub_it->second.Get<SubscribeTrackHandler>(); sub_handler) { |
Contributor
There was a problem hiding this comment.
Suggested change
| if (auto sub_handler = sub_it->second.Get<SubscribeTrackHandler>(); sub_handler) { | |
| if (auto sub_handler = sub_it->second.Get<SubscribeTrackHandler>()) { |
| static_cast<FetchTrackHandler*>(fetch_it->second.handler.get())->SetLatestLocation(msg.end_location); | ||
| static_cast<FetchTrackHandler*>(fetch_it->second.handler.get()) | ||
| ->SetStatus(FetchTrackHandler::Status::kOk); | ||
| if (auto h = fetch_it->second.Get<FetchTrackHandler>(); h) { |
Contributor
There was a problem hiding this comment.
Technically don't need to add the ; h since the result of Get returns a pointer which is implicitly checked for null.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change also combines libquicr pub/sub tracking by request id to single
requestsmap.