Skip to content

Comments

feat(contract): enhance get_mission with comprehensive query functions#49

Merged
Kaylahray merged 7 commits intoQuid-proquo:mainfrom
LaGodxy:feat/contract-get-mission-query
Feb 21, 2026
Merged

feat(contract): enhance get_mission with comprehensive query functions#49
Kaylahray merged 7 commits intoQuid-proquo:mainfrom
LaGodxy:feat/contract-get-mission-query

Conversation

@LaGodxy
Copy link
Contributor

@LaGodxy LaGodxy commented Feb 20, 2026

  • Added get_missions for batch querying multiple missions
  • Added mission_exists for lightweight existence checking
  • Added get_mission_reward for optimized reward information fetching
  • Added get_mission_status for lightweight status queries
  • Enhanced documentation with detailed examples
  • Added comprehensive tests for all new query functions
  • All 21 tests passing successfully

These functions provide optimized read-only access for frontend UI
to verify mission details, rewards, and status efficiently."

closes #35

Copy link
Contributor

@Kaylahray Kaylahray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @LaGodxy Please Kindly Pull and fix workflow errors,

@LaGodxy
Copy link
Contributor Author

LaGodxy commented Feb 21, 2026

@Kaylahray approve the workflow, it will be best to leave to be automatic approval please.

@Kaylahray
Copy link
Contributor

Kaylahray commented Feb 21, 2026

@Kaylahray approve the workflow, it will be best to leave to be automatic approval please.

Thanks @LaGodxy I'll do that to run automatically, for now, I need you to run these commands
cargo fmt --all
cargo clippy --all-targets --all-features -- -D warnings

tag me when you're done. Thank you 🙋‍♀️

@LaGodxy
Copy link
Contributor Author

LaGodxy commented Feb 21, 2026

@Kaylahray

@Kaylahray
Copy link
Contributor

Kaylahray commented Feb 21, 2026

image

@LaGodxy

@LaGodxy
Copy link
Contributor Author

LaGodxy commented Feb 21, 2026

@Kaylahray

I do not think you understood me, set your github action to be auto, I cant be waiting for you to always approve, its usual with pipeline to pass locally and fail here in github, when you set to auto I can work faster no need for you to always approve,

@Kaylahray
Copy link
Contributor

image

@LaGodxy

@Kaylahray
Copy link
Contributor

Kaylahray commented Feb 21, 2026

@Kaylahray

I do not think you understood me, set your github action to be auto, I cant be waiting for you to always approve, its usual with pipeline to pass locally and fail here in github, when you set to auto I can work faster no need for you to always approve,

I did understand, I'll fix that. Thank you 🙋‍♀️. sorry for the inconvenience.

@Kaylahray
Copy link
Contributor

image

@LaGodxy

@LaGodxy
Copy link
Contributor Author

LaGodxy commented Feb 21, 2026

image @LaGodxy

@Kaylahray tick the first one, not the second.

@Kaylahray
Copy link
Contributor

image @LaGodxy

@Kaylahray tick the first one, not the second.

Thank you. I've done that. @LaGodxy

@LaGodxy
Copy link
Contributor Author

LaGodxy commented Feb 21, 2026

@Kaylahray done.

@Kaylahray Kaylahray merged commit 43cb9c4 into Quid-proquo:main Feb 21, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Contract] Implement 'get_mission' View

2 participants