improve status bar with stat generation progress #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ix0rai
added
backend
IotaBread
reviewed
Feb 26, 2024
enigma-swing/src/main/java/org/quiltmc/enigma/gui/node/ClassSelectorClassNode.java
Outdated
Show resolved
Hide resolved
…uded based on what's currently editable
IotaBread
approved these changes
Mar 5, 2024
| @@ -167,8 +168,15 @@ public CompletableFuture<Void> openMappings(MappingFormat format, Path path) { | |||
| this.refreshClasses(); | |||
| this.chp.invalidateJavadoc(); | |||
| this.statsGenerator = new StatsGenerator(this.project); | |||
| new Thread(() -> { | |||
There was a problem hiding this comment.
This is already inside another secondary thread, and I feel like we have a better way to spawn threads instead of new Thread()
There was a problem hiding this comment.
I have no idea what the best way of doing this would be, this is kinda a bodge that just got left in because I don't know what's better
|
thanks gorge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--no-edit-x) #184