Skip to content

Commit

Permalink
Fix QuiltLoaderImpl.copiedToJarMods never being populated, which indi…
Browse files Browse the repository at this point in the history
…rectly works around Java 8's URL handling not working correctly for jar paths. (#463)
  • Loading branch information
AlexIIL committed Dec 28, 2024
1 parent e39ce88 commit 5cdba61
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 2 deletions.
2 changes: 1 addition & 1 deletion gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ group = org.quiltmc
description = The mod loading component of Quilt
url = https://github.com/quiltmc/quilt-loader
# Don't forget to change this in QuiltLoaderImpl as well
quilt_loader = 0.28.0-beta.3
quilt_loader = 0.28.0-beta.4

# Fabric & Quilt Libraries
asm = 9.7.1
Expand Down
4 changes: 3 additions & 1 deletion src/main/java/org/quiltmc/loader/impl/QuiltLoaderImpl.java
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ public final class QuiltLoaderImpl {

public static final int ASM_VERSION = Opcodes.ASM9;

public static final String VERSION = "0.28.0-beta.3";
public static final String VERSION = "0.28.0-beta.4";
public static final String MOD_ID = "quilt_loader";
public static final String DEFAULT_MODS_DIR = "mods";
public static final String DEFAULT_CACHE_DIR = ".cache";
Expand Down Expand Up @@ -580,6 +580,8 @@ private Path copyToJar(Path transformCacheFolder, ModLoadOption modOption, final
FilePreloadHelper.preLoad(modJarFile);
}

copiedToJarMods.put(modOption.id(), modJarFile.toFile());

try {
FileSystem fs = FileSystems.newFileSystem(modJarFile, (ClassLoader) null);
return fs.getPath("/");
Expand Down
1 change: 1 addition & 0 deletions src/main/resources/changelog/0.28.0.txt
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,5 @@ Bug Fixes:
- Fixed server libraries not being identified properly with newer quilt-server-launcher.
- Fixed mod files being searched in preference to minecraft library files.
- This fixes a bug with Valkyrien-Skies-2 stopping log messages.
- [#463] Fixed jar copied mods not being handled correctly in Java 8.

0 comments on commit 5cdba61

Please sign in to comment.