Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Begin QMJ Writer #446

Closed
wants to merge 4 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
import org.quiltmc.loader.impl.util.log.LogCategory;

@QuiltLoaderInternal(QuiltLoaderInternalType.LEGACY_EXPOSED)
final class V1ModMetadataFabric extends AbstractModMetadata implements FabricLoaderModMetadata {
public final class V1ModMetadataFabric extends AbstractModMetadata implements FabricLoaderModMetadata {
static final IconEntry NO_ICON = size -> Optional.empty();

// Required values
Expand Down Expand Up @@ -76,7 +76,7 @@ final class V1ModMetadataFabric extends AbstractModMetadata implements FabricLoa
private final Collection<Person> contributors;
private final ContactInformation contact;
private final Collection<String> license;
private final IconEntry icon;
public final IconEntry icon;

// Optional (language adapter providers)
private final Map<String, String> languageAdapters;
Expand Down Expand Up @@ -346,12 +346,12 @@ static final class MixinEntry {
}
}

interface IconEntry {
public interface IconEntry {
Optional<String> getIconPath(int size);
}

static final class Single implements IconEntry {
private final String icon;
public static final class Single implements IconEntry {
public final String icon;

Single(String icon) {
this.icon = icon;
Expand All @@ -363,8 +363,8 @@ public Optional<String> getIconPath(int size) {
}
}

static final class MapEntry implements IconEntry {
private final SortedMap<Integer, String> icons;
public static final class MapEntry implements IconEntry {
public final SortedMap<Integer, String> icons;

MapEntry(SortedMap<Integer, String> icons) {
this.icons = icons;
Expand Down
4 changes: 2 additions & 2 deletions src/main/java/org/quiltmc/loader/impl/metadata/qmj/Icons.java
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public interface Icons {
@QuiltLoaderInternal(QuiltLoaderInternalType.LEGACY_EXPOSED)
public final class Single implements Icons {
@Nullable
private final String icon;
final String icon;

public Single(@Nullable String icon) {
this.icon = icon;
Expand All @@ -57,7 +57,7 @@ public String getIcon(int size) {
*/
@QuiltLoaderInternal(QuiltLoaderInternalType.LEGACY_EXPOSED)
public final class Multiple implements Icons {
private final SortedMap<Integer, String> icons;
final SortedMap<Integer, String> icons;

public Multiple(SortedMap<Integer, String> icons) {
this.icons = icons;
Expand Down
Loading
Loading