Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some nbt work #612

Merged
merged 5 commits into from
Aug 8, 2024
Merged

some nbt work #612

merged 5 commits into from
Aug 8, 2024

Conversation

ix0rai
Copy link
Member

@ix0rai ix0rai commented Jul 16, 2024

aiming to complete n.m.nbt

@ix0rai ix0rai added t: new adds new mappings v: release targets a release version of minecraft wip this is a work in progress s: tiny PRs with less than 50 lines labels Jul 16, 2024
@ix0rai ix0rai marked this pull request as ready for review August 7, 2024 03:25
@ix0rai ix0rai added reviews needed please review this PR s: small PRs with less than 200 lines and removed wip this is a work in progress s: tiny PRs with less than 50 lines labels Aug 7, 2024
@ix0rai
Copy link
Member Author

ix0rai commented Aug 7, 2024

complete!

supersaiyansubtlety
supersaiyansubtlety reviewed Aug 7, 2024
View reviewed changes
Copy link
Contributor

@supersaiyansubtlety supersaiyansubtlety left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpicks

mappings/net/minecraft/nbt/NbtOps.mapping Outdated Show resolved Hide resolved
mappings/net/minecraft/nbt/NbtOps.mapping Outdated Show resolved Hide resolved
ix0rai and others added 2 commits August 6, 2024 22:54
@ix0rai @supersaiyansubtlety
Update mappings/net/minecraft/nbt/NbtOps.mapping
3944dcb 
Co-authored-by: Will <supersaiyansubtlety@gmail.com>
@ix0rai @supersaiyansubtlety
Update mappings/net/minecraft/nbt/NbtOps.mapping
6008096 
Co-authored-by: Will <supersaiyansubtlety@gmail.com>
@supersaiyansubtlety supersaiyansubtlety added final-comment-period is approved and will soon be merged if no issues are raised and removed reviews needed please review this PR labels Aug 7, 2024
@OroArmor OroArmor added the update-base used to notify github actions that the base branch should be updated label Aug 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 7, 2024

🚀 Target branch has been updated to 1.21.1-rc1

@github-actions github-actions bot changed the base branch from 1.21 to 1.21.1-rc1 August 7, 2024 16:28
@github-actions github-actions bot added v: snapshot targets a snapshot version of minecraft and removed update-base used to notify github actions that the base branch should be updated v: release targets a release version of minecraft labels Aug 7, 2024
@ix0rai ix0rai merged commit 40b8dba into QuiltMC:1.21.1-rc1 Aug 8, 2024
@ix0rai ix0rai deleted the nbt branch August 8, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@supersaiyansubtlety supersaiyansubtlety supersaiyansubtlety approved these changes

@OroArmor OroArmor OroArmor approved these changes

Assignees
No one assigned
Labels
final-comment-period is approved and will soon be merged if no issues are raised s: small PRs with less than 200 lines t: new adds new mappings v: snapshot targets a snapshot version of minecraft
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ix0rai @supersaiyansubtlety @OroArmor