Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some mappings for worldrenderer #619

Merged
merged 10 commits into from
Aug 1, 2024
Merged

some mappings for worldrenderer #619

merged 10 commits into from
Aug 1, 2024

Conversation

woodiertexas
Copy link
Contributor

No description provided.

supersaiyansubtlety
supersaiyansubtlety requested changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@supersaiyansubtlety supersaiyansubtlety left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since all the matrix4f params are along side other Martrix4f params, they should have more descriptive names.

mappings/net/minecraft/unmapped/ChunkBuilder.mapping Outdated Show resolved Hide resolved
OroArmor
OroArmor requested changes Jul 24, 2024
View reviewed changes
Copy link
Member

@OroArmor OroArmor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the matrix4f parameters are probably the viewMatrix. HOWEVER, i would recheck that something didnt change because the order is usually model, view, then projection, but it seems that projection is before view, which is odd.

mappings/net/minecraft/client/render/WorldRenderer.mapping Outdated Show resolved Hide resolved
mappings/net/minecraft/client/render/WorldRenderer.mapping Outdated Show resolved Hide resolved
woodiertexas and others added 2 commits July 23, 2024 21:37
@woodiertexas @OroArmor
Update mappings/net/minecraft/client/render/WorldRenderer.mapping
802dbae 
Co-authored-by: Eli Orona <eliorona@live.com>
@woodiertexas @OroArmor
Update mappings/net/minecraft/client/render/WorldRenderer.mapping
66f2ddd 
Co-authored-by: Eli Orona <eliorona@live.com>
@woodiertexas
Copy link
Contributor Author

woodiertexas commented Jul 24, 2024 •
edited
Loading

the matrix4f parameters are probably the viewMatrix. HOWEVER, i would recheck that something didnt change because the order is usually model, view, then projection, but it seems that projection is before view, which is odd.

yea, they were matrix4f when i was cross-referencing WorldRenderer in enigma with WorldRenderer.java in the intelliJ planetarium project

@woodiertexas
Copy link
Contributor Author

the matrix4f parameters are probably the viewMatrix. HOWEVER, i would recheck that something didnt change because the order is usually model, view, then projection, but it seems that projection is before view, which is odd.

in enigma:
java_AVFFJSPAU1

in the planetarium project:
idea64_JGZThcg3bH

@woodiertexas woodiertexas changed the title some mappings for worldrenderer and one picomapping for chunkbuilder some mappings for worldrenderer Jul 24, 2024
@IotaBread IotaBread added t: new adds new mappings v: release targets a release version of minecraft s: tiny PRs with less than 50 lines labels Jul 24, 2024
ix0rai
ix0rai requested changes Jul 25, 2024
View reviewed changes
Copy link
Member

@ix0rai ix0rai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good; besides the matrix4f parameters

@woodiertexas
Copy link
Contributor Author

looks good; besides the matrix4f parameters

so what name would you give those parameters?

OroArmor
OroArmor requested changes Jul 26, 2024
View reviewed changes
Copy link
Member

@OroArmor OroArmor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed by double checking the Frustrum constructor mapping

mappings/net/minecraft/client/render/WorldRenderer.mapping Outdated Show resolved Hide resolved
mappings/net/minecraft/client/render/WorldRenderer.mapping Outdated Show resolved Hide resolved
mappings/net/minecraft/client/render/WorldRenderer.mapping Outdated Show resolved Hide resolved
@OroArmor OroArmor self-requested a review July 26, 2024 23:56
@OroArmor OroArmor added the update-base used to notify github actions that the base branch should be updated label Jul 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

🚨 Target branch is already set to 1.21

@github-actions github-actions bot removed the update-base used to notify github actions that the base branch should be updated label Jul 26, 2024
woodiertexas and others added 2 commits July 26, 2024 20:27
@woodiertexas @OroArmor
Update mappings/net/minecraft/client/render/WorldRenderer.mapping
20a5665 
Co-authored-by: Eli Orona <eliorona@live.com>
@woodiertexas @OroArmor
Update mappings/net/minecraft/util/math/MathHelper.mapping
694ede0 
Co-authored-by: Eli Orona <eliorona@live.com>
@OroArmor OroArmor requested a review from ix0rai July 31, 2024 18:33
@OroArmor OroArmor added the final-comment-period is approved and will soon be merged if no issues are raised label Jul 31, 2024
@OroArmor OroArmor merged commit 24ea1b0 into QuiltMC:1.21 Aug 1, 2024
3 checks passed
@woodiertexas woodiertexas deleted the worldrenderer-mappings branch August 1, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ix0rai ix0rai ix0rai approved these changes

@OroArmor OroArmor OroArmor approved these changes

@supersaiyansubtlety supersaiyansubtlety supersaiyansubtlety approved these changes

Assignees
No one assigned
Labels
final-comment-period is approved and will soon be merged if no issues are raised s: tiny PRs with less than 50 lines t: new adds new mappings v: release targets a release version of minecraft
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@woodiertexas @supersaiyansubtlety @OroArmor @ix0rai @IotaBread