Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete nearly everything in item #623

Merged
merged 4 commits into from
Aug 4, 2024
Merged

Complete nearly everything in item #623

merged 4 commits into from
Aug 4, 2024

Conversation

diacritics-owo
Copy link
Contributor

First Quilt contribution. As per the title, I've written mappings for everything in item except for some of CrossbowItem and ItemStack.

@ix0rai ix0rai added t: new adds new mappings v: release targets a release version of minecraft reviews needed please review this PR s: small PRs with less than 200 lines labels Jul 31, 2024
OroArmor
OroArmor requested changes Jul 31, 2024
View reviewed changes
Copy link
Member

@OroArmor OroArmor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small changes

mappings/net/minecraft/item/Item.mapping Outdated Show resolved Hide resolved
mappings/net/minecraft/item/CrossbowItem.mapping Outdated Show resolved Hide resolved
@diacritics-owo @OroArmor
Apply suggestions
477413b 
Co-authored-by: Eli Orona <eliorona@live.com>
@diacritics-owo
Copy link
Contributor Author

I've applied the suggestions! Let me know if there's anything else

supersaiyansubtlety
supersaiyansubtlety approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@supersaiyansubtlety supersaiyansubtlety left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why would Mojang do this to us in particular register("banner_white", "white_banner"...
looks good

@OroArmor OroArmor added final-comment-period is approved and will soon be merged if no issues are raised and removed reviews needed please review this PR labels Aug 2, 2024
@OroArmor OroArmor merged commit 1d531a3 into QuiltMC:1.21 Aug 4, 2024
1 check passed
@diacritics-owo diacritics-owo deleted the 1.21 branch August 4, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@supersaiyansubtlety supersaiyansubtlety supersaiyansubtlety approved these changes

@OroArmor OroArmor OroArmor approved these changes

Assignees
No one assigned
Labels
final-comment-period is approved and will soon be merged if no issues are raised s: small PRs with less than 200 lines t: new adds new mappings v: release targets a release version of minecraft
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@diacritics-owo @supersaiyansubtlety @OroArmor @ix0rai