Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a mappings server task #644

Merged
merged 8 commits into from
Oct 3, 2024
Merged

Add a mappings server task #644

merged 8 commits into from
Oct 3, 2024

Conversation

IotaBread
Copy link
Member

No description provided.

@IotaBread IotaBread added enhancement new feature or request t: toolchain changes to the quilt mappings toolchain v: snapshot targets a snapshot version of minecraft s: tiny PRs with less than 50 lines labels Sep 25, 2024
@ix0rai
Copy link
Member

ix0rai commented Sep 28, 2024

doesn't seem to run for me

A problem was found with the configuration of task ':mappingsServer' (type 'EnigmaMappingsServerTask').
  - Type 'quilt.internal.tasks.mappings.EnigmaMappingsServerTask' field 'mappings' without corresponding getter has been annotated with @InputFile.

am i doing something wrong?

@supersaiyansubtlety
Copy link
Contributor

confirmed, working on a fix

@IotaBread @supersaiyansubtlety
Apply suggestions from code review
573f07f 
Co-authored-by: Will <supersaiyansubtlety@gmail.com>
@IotaBread
Copy link
Member Author

Applied the suggestions

@supersaiyansubtlety
Copy link
Contributor

supersaiyansubtlety commented Sep 28, 2024 •
edited
Loading

in the future I'll PR to the PR source instead of making piecemeal suggestions

@IotaBread @supersaiyansubtlety
Update buildSrc/src/main/java/quilt/internal/tasks/mappings/EnigmaMap…
ae28956 
…pingsServerTask.java

Co-authored-by: Will <supersaiyansubtlety@gmail.com>
@supersaiyansubtlety supersaiyansubtlety mentioned this pull request Sep 28, 2024
Open
14 tasks
@ix0rai ix0rai added the update-base used to notify github actions that the base branch should be updated label Oct 1, 2024
@github-actions github-actions bot changed the base branch from 24w38a to 24w39a October 1, 2024 15:08
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 1, 2024

🚀 Target branch has been updated to 24w39a

@github-actions github-actions bot removed the update-base used to notify github actions that the base branch should be updated label Oct 1, 2024
@ix0rai ix0rai added the update-base used to notify github actions that the base branch should be updated label Oct 3, 2024
@github-actions github-actions bot changed the base branch from 24w39a to 24w40a October 3, 2024 00:36
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 3, 2024

🚀 Target branch has been updated to 24w40a

@github-actions github-actions bot removed the update-base used to notify github actions that the base branch should be updated label Oct 3, 2024
@ix0rai ix0rai added s: small PRs with less than 200 lines and removed s: tiny PRs with less than 50 lines labels Oct 3, 2024
ix0rai
ix0rai approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@ix0rai ix0rai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! (and works)

@OroArmor OroArmor added the final-comment-period is approved and will soon be merged if no issues are raised label Oct 3, 2024
@OroArmor OroArmor merged commit d03d93b into QuiltMC:24w40a Oct 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ix0rai ix0rai ix0rai approved these changes

@OroArmor OroArmor OroArmor approved these changes

@supersaiyansubtlety supersaiyansubtlety supersaiyansubtlety approved these changes

Assignees
No one assigned
Labels
enhancement new feature or request final-comment-period is approved and will soon be merged if no issues are raised s: small PRs with less than 200 lines t: toolchain changes to the quilt mappings toolchain v: snapshot targets a snapshot version of minecraft
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@IotaBread @ix0rai @supersaiyansubtlety @OroArmor