Issue332 create new spectrogram types #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue #332 Set up basic structure for including mel-scale and octave-scale spectrograms in the type of generated standard scale spectrograms..
Issue #332 There was a limited number of colours to use as tags for different spectrogram types. By adding two new spectrograms, there was an insufficient number of colours. Changed the colour palette.
Issue #332 Get Mel frequency scale spectrograms working. Start work on Octave scale spectrograms.
Issue #332 Get Octave spectrograms going.
Issue #332 Change names of hte main frequency scale types and remove old methods that used to do tests.
Issue #332 Shift methods to do with Mel scale to the SpectrogramMelScale class.
Issue #332 Add tests and rework existing tests for frequency scales
Issue #332 Also have one change required in IndexCalculateTests. This may cause the test to fail.
Issue #332 This will create conflict in another brnach. Easy to fix. Accept Hanning as default window.
Issue #332 Add another constructor which accepts FreqScale as argument
Issue #332
Issue #332 Also need to add a new test for calculating grid locations and fix other tests.
Issue #332 Previously calculated an octave scale that was once used for a high SR marine recording. Now implement an octave scale that is used for spectral data reduction. This will be used subsequently for content description.
Codecov Report
@@ Coverage Diff @@
## master #353 +/- ##
==========================================
+ Coverage 29.30% 37.83% +8.52%
==========================================
Files 475 478 +3
Lines 68793 70917 +2124
Branches 0 8002 +8002
==========================================
+ Hits 20161 26831 +6670
+ Misses 48632 44003 -4629
- Partials 0 83 +83
Continue to review full report at Codecov.
|
Issue 332 Add in new image for ribbon spectrograms. This is for debug purposes when want to see what is happening during data reduction.
Issue #332 Add in new methods for rescaling frequency but keeping linear.
Issue #332 Finalise test for conversion of amplitude to octave frequency scale
Issue #332 Shift filterBank methods to Spectrum tools because they are now generalised for all frequency scale transformations.
Issue #332 Now that have ability to visualise a data reduced spectrogram, I changed it to give better distribution of filterbanks.
Issue #332
The color tag was omitted from the title bar of a few of the new spectrograms. Also made it easier to print out C# multi-dimensional array literals. Useful for updating large test values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title of PR
Fixed octave frequency scale and display of additional spectrograms
Changes
All code to do with the octave frequency scale
Issues
The changes on this branch required changing the default FFT window to Hanning. This is also the issue in another pull request #349. Suggest that Pull request #349 should be merged with master before this pull request.
Visual Changes
Generate spectrograms now makes more types of spectrogram with octave freq scale.
Final Checklist