Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ability to set cli commands #6758

Closed
wants to merge 1 commit into from

Conversation

azat-io
Copy link

@azat-io azat-io commented Aug 3, 2024

Overview

QwikDev/qwik-evolution#28

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos

Description

Add the ability to specify a command name for the Qwik application build.

Use cases and why

This can be useful if the repository contains code for more than just the site.

For example, library code and site code with documentation. It would be convenient to separate commands by name.

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

@azat-io azat-io requested a review from a team as a code owner August 3, 2024 11:21
Copy link

changeset-bot bot commented Aug 3, 2024

🦋 Changeset detected

Latest commit: 3100939

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@builder.io/qwik Minor
eslint-plugin-qwik Minor
@builder.io/qwik-city Minor
create-qwik Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@wmertens
Copy link
Member

wmertens commented Sep 8, 2024

I'm not convinced - you still have to call the qwik script with the paramaters and have an npm script defined.

Can you give a real scenario and then we can brainstorm what the ideal CLI API for that would be?

@wmertens
Copy link
Member

wmertens commented Oct 6, 2024

Hi @azat-io, I propose you create an RFC discussion so we can flesh out what it should look like, see https://github.com/QwikDev/qwik-evolution?tab=readme-ov-file#qwik-rfc-process

In the meantime I'll close this PR but once we agree on how to proceed we can continue on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants