Skip to content

Conversation

@wmertens
Copy link
Member

No description provided.

@wmertens wmertens requested review from a team as code owners October 29, 2025 19:25
@changeset-bot
Copy link

changeset-bot bot commented Oct 29, 2025

⚠️ No Changeset found

Latest commit: 3eb3ca5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Oct 29, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 3eb3ca5

Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪🙏

@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 30, 2025

Open in StackBlitz

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@8101
npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@8101
npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@8101
npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@8101

commit: 3eb3ca5

@wmertens wmertens force-pushed the v2-merge-main branch 2 times, most recently from 5aa8e2d to b472cdf Compare October 31, 2025 10:34
keeping the window and attributes as-is actually compresses better than using string indexing
@wmertens wmertens requested a review from a team as a code owner October 31, 2025 13:51
Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wmertens wmertens marked this pull request as draft October 31, 2025 14:56
@wmertens wmertens marked this pull request as ready for review October 31, 2025 15:39
@wmertens wmertens merged commit 3748a24 into build/v2 Oct 31, 2025
21 checks passed
@wmertens wmertens deleted the v2-merge-main branch October 31, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants