Add RequestEvent clients getter #8104
Draft
+7
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description
Interfacing with API clients in loaders and server$ functions is a common use case for REST, gRPC, and GraphQL servers.
To share clients on the RequestEvent, the only possible solution is to store it in the sharedMap which makes using them cumbersome:
It would be better to have a DX similar to this:
To achieve this, we would need to add a getter to the RequestEvent object which returns
ev.sharedMap.get("qwik-api-clients").This way, it's easy for users to extend the RequestEvent with their API clients:
Checklist
pnpm change