Basic build instructions #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catornot
requested changes
Oct 15, 2023
|
|
||
| The Northstar RPC plugin uses [cargo](https://doc.rust-lang.org/cargo/index.html) to download dependencies and build code | ||
|
|
||
| Run `cargo build --release` in the root directory of the plugin. The output will be found in `target/release`. |
There was a problem hiding this comment.
release is not required to build the plugin, it only disables the plugin from throwing errors and forces it to shutdown instead also ofc it optimizes it.
There was a problem hiding this comment.
I though @itscynxx had issues with getting the plugin running without compiling as release? Or did I confuse something here? ^^"
There was a problem hiding this comment.
cargo build should work fine. idk why someone would have issues unless they are building on linux :|
There was a problem hiding this comment.
So running cargo build worked just fine for me on Windows (on plugins v3).
|
Imma move this to post plugins v3 |
|
Closing as isn't needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried running the instructions found from the GitHub workflow and that didn't work, asked in the Discord and got this which did work
Maybe wording could be better though?