Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin rrplug version to 3.0.0 #14

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Pin rrplug version to 3.0.0 #14

merged 1 commit into from
Nov 15, 2023

Conversation

catornot
Copy link
Member

@catornot catornot commented Nov 7, 2023

also fixes things because of rrplug changes :P

@catornot catornot changed the title Pin to rrplug version to 3 Pin rrplug version to 3 Nov 7, 2023
GeckoEidechse
GeckoEidechse reviewed Nov 14, 2023
View reviewed changes
Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably should get someone to test this and then should be good to merge. I see two smaller unrelated changes that I'm gonna quickly do myself.

As a sidenote, we should do like format check and clippy on CI for DiscordRPC ^^

Cargo.toml Show resolved Hide resolved
GeckoEidechse
GeckoEidechse approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@GeckoEidechse GeckoEidechse left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed working in testing. Joined a few servers and saw status update in Discord.

@GeckoEidechse GeckoEidechse changed the title Pin rrplug version to 3 Pin rrplug version to 3.0.0 Nov 15, 2023
@GeckoEidechse GeckoEidechse merged commit 58f1bb1 into R2Northstar:main Nov 15, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeckoEidechse GeckoEidechse GeckoEidechse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Northstar Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@catornot @GeckoEidechse