Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW] Fix Reversed Titan Spawnpoint on Boomtown #580

Merged
merged 3 commits into from May 1, 2023
Merged

[FW] Fix Reversed Titan Spawnpoint on Boomtown #580

merged 3 commits into from May 1, 2023

Conversation

ghost
Copy link

@ghost ghost commented Jan 22, 2023

Respawn left a reversed titan start point on Boomtown( mp_grave ), which will make fw's "Respawn as Titan" have a wrong start point

Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed working in testing.

Tested in 1-player listen server, 2 rounds of Frontier War on Boomtown, one with PR one without. Without PR respawn with Titan on wrong side, with PR correct side.

Also tested 1 round on Forwardbase Kodai just to be sure the PR doesn't break anything by accident :P

@GeckoEidechse GeckoEidechse added needs code review Changes from PR still need to be reviewed in code almost ready to merge Apart from any small remaining other issues addressed by other labels, this would be ready to merge labels Feb 2, 2023
Copy link
Contributor

@ASpoonPlaysGames ASpoonPlaysGames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be potentially better to simply edit the .ent files (through keyvalues or something) to fix the bad spawns?

@ghost
Copy link
Author

ghost commented Feb 2, 2023

Would it be potentially better to simply edit the .ent files (through keyvalues or something) to fix the bad spawns?

the spawn points are decided for ttdm or some other respawn as titan conditions, they're never considered about fw I guess, so my way to fix it is add a hack in _gamemode_fw. Also changing fw related spawnpoints will cause minimap territory issues, which related in .bsp file IIRC ( #573 )

@F1F7Y
Copy link
Member

F1F7Y commented Apr 21, 2023

Also changing fw related spawnpoints will cause minimap territory issues

The minimap territory image is in an rpak, the actuall territory volume is defined using triggers in the .bsp so this is false

Copy link
Member

@F1F7Y F1F7Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works in testing, code looks good

@F1F7Y F1F7Y removed the needs code review Changes from PR still need to be reviewed in code label Apr 21, 2023
Copy link
Contributor

@uniboi uniboi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kind of a workaround but it's fine. Code looks good, there isn't a lot to review really

@GeckoEidechse GeckoEidechse merged commit ff90171 into R2Northstar:main May 1, 2023
@GeckoEidechse GeckoEidechse removed the almost ready to merge Apart from any small remaining other issues addressed by other labels, this would be ready to merge label May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants